Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to new s3 bucket #1137

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Move to new s3 bucket #1137

merged 1 commit into from
Sep 17, 2023

Conversation

dims
Copy link
Member

@dims dims commented Sep 16, 2023 •
edited
Loading

New account means new bucket :)

related to : kubernetes/k8s.io#5194

pulled in fix from @torredil here #1138

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2023
@dims
Copy link
Member Author

dims commented Sep 16, 2023

/assign @torredil @jacobwolfaws @tzneal

@dims
Copy link
Member Author

dims commented Sep 16, 2023

made some progress, now stuck with Access Denied. Please ensure you have the right AWS permissions: Access denied please see:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-efs-csi-driver/1137/pull-aws-efs-csi-driver-e2e/1702866666553085952/build-log.txt

docs point to ClientRootAccess https://docs.aws.amazon.com/efs/latest/ug/efs-access-points.html#efs-access-poiont-create - where do we need to specify that?

@dims dims changed the title Move to new s3 bucket [WIP] Move to new s3 bucket Sep 16, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2023
@dims dims mentioned this pull request Sep 16, 2023
Closed
8 tasks
@torredil
Copy link
Member

/test pull-aws-efs-csi-driver-unit

@dims dims changed the title [WIP] Move to new s3 bucket Move to new s3 bucket Sep 16, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2023
@dims
Move to new s3 bucket
92d8835 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
torredil
torredil approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@torredil
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2023
@dims dims added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dims, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3568fe into kubernetes-sigs:master Sep 17, 2023
2 checks passed
@seanzatzdev-amazon seanzatzdev-amazon mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@d-nishi d-nishi Awaiting requested review from d-nishi

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@tzneal tzneal

@torredil torredil

@jacobwolfaws jacobwolfaws

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @torredil @k8s-ci-robot @tzneal @jacobwolfaws